Masterminds / Masterminds/html5-php

InstructionProcessor doesn't work in text mode.

Open
#227 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
1.8k
Forks
122
PR merge metrics
No merged PRs in 30d

Description

If the tokenizer enters 'text mode' then no other tags are parsed. I don't know the spec well enough to know whether it should or not.

Example:

<!DOCTYPE html>
<html lang="<?l en ?>"> <-- not processed
<head>
    <title><?s Title ?></title> <-- not processed
</head>
<body>
<p><?s hello world ?></p> <-- processed
</body>
</html>

possibly related: #211

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the tokenizer's text-mode handling and InstructionProcessor, using the HTML example in this issue and related issue #211 as context. Establish whether instruction tags should be recognized in text mode; done means the expected behavior is implemented and covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.