MarshallOfSound / MarshallOfSound/react-electron-web-view
Remove created event listeners on unmount
Open
- Dominant language
- JavaScript
- Stars
- 64
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
In order to avoid memory leaks, component **should clean after itself** and call `removeEventListener` for every listener declared on `componentDidMount`.
See [related official docs](https://react-cn.github.io/react/tips/dom-event-listeners.html).
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the componentDidMount implementation and inventory the event listeners declared there. Read the linked React DOM event-listener guidance, then verify that unmount cleanup covers every listener and that the component no longer retains them after unmount.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100