MarshallOfSound / MarshallOfSound/electron-devtools-installer
fs.rmdir() deprecated
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 151
- PR merge metrics
- No merged PRs in 30d
Description
When installing devtools extensions in electron 41.1.1, I get this warning thrown in the console:
(node:12656) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
It seems that in downloadChromeExtension.ts, this
await fs.promises.rmdir(extensionFolder, {
recursive: true,
});
should be changed to this instead
await fs.promises.rm(extensionFolder, {
recursive: true,
});
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open downloadChromeExtension.ts and inspect the fs.promises.rmdir call that uses recursive removal. Replace the deprecated operation with the indicated alternative, then verify that installing a DevTools extension no longer emits the DEP0147 warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, node.js, typescript
- Domain
- desktop, tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100