MarketSquare / MarketSquare/robotframework-seleniumscreenshots
Font family parameter
Nobody has claimed this yet.
- Dominant language
- Nix
- Stars
- 11
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
Hello.
The library is awesome!
I just made some little adjustments to __init__.py and 2 of the .js files in resources folder (i.e. add_dot.js and add_note.js) to add a new parameter (fontfamily) to the related keywords to set also the font family (serif, sans-serif or other) of the text (also changed the default family to sans-serif).
I'm attaching here the zip with modified files, for your check/validation and inclusion in a new version of the library.
[SeleniumScreenshots_Modifiedfiles.zip](https://github.com/datakurre/robotframework-seleniumscreenshots/files/4616907/SeleniumScreenshots_Modifiedfiles.zip)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review __init__.py, resources/add_dot.js, and resources/add_note.js, then inspect the attached modified-files archive. Verify how the related Robot Framework keywords receive parameters and whether the requested fontfamily values and sans-serif default are covered; done means the changes work consistently in the affected keywords.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, python
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100