MarketSquare / MarketSquare/robotframework-requests
Verify=False is not propogated to bypass ssl verification
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 512
- Forks
- 283
- PR merge metrics
- No merged PRs in 30d
Description
Version: 7.0 (Python 3.10.12 on linux)
ref this https://forum.robotframework.org/t/how-to-make-requests-library-ignore-ssl-errors/6790/8
in _common_request() function
```
resp = method_function(
self._merge_url(session, uri), <- session has verify:False but it is not passed to kwargs
timeout=self._get_timeout(kwargs.pop('timeout', None)),
cookies=kwargs.pop('cookies', self.cookies),
**kwargs)
```
log.logger.error(kwargs) <- this is missing Verify: False
kwargs.update({'verify': False}) <- if I add it it works
My guess this is missing
```
kwargs.update({'verify': session.verify})
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the _common_request() function and trace how session.verify is handled before method_function is called. Confirm that a session configured with verify=False passes that value through to the request, and verify that SSL verification is bypassed as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100