MarketSquare / MarketSquare/robotframework-requests

could post data encoding support other except utf8

Open
#362 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
512
Forks
283
PR merge metrics
No merged PRs in 30d

Description

`_utf8_urlencode` in utils.py is encoding by utf8, could it support other such as gbk?
could it use `content-type` request header if `charset` in it, then use this to encoding?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in utils.py at _utf8_urlencode and inspect how request data is encoded and how headers are available. Determine how charset values such as gbk should be selected from the content-type header, then add coverage for non-UTF-8 encoding and verify existing UTF-8 behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.