MarketSquare / MarketSquare/robotframework-browser
Presenter mode question
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 655
- Forks
- 147
- Avg merge
- 5h 27m
- Merged PRs (30d)
- 59
Description
Hi
I'm curious why hardcoded 5 seconds sleep is implemented under [_end_test](https://github.com/MarketSquare/robotframework-browser/blob/4bb43db89fc5194aff126ee13ab01a44036cbeba/Browser/browser.py#L1287) method (only here and only for AutoClosingLevel == TEST) when presenter mode is enabled. Is there any reason why there is a wait here - if so, then maybe it could be parameterized?
Thanks in advance for info.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open Browser/browser.py at the linked _end_test method and inspect the presenter-mode path around the hardcoded five-second sleep. Read the issue comments for the existing rationale before deciding whether a change is wanted. Done means the wait behavior has a documented decision and any accepted adjustment has a clear parameter and verification plan.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- playwright, python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100