MarketSquare / MarketSquare/robotframework-browser

Keyword "Set Browser Timeout": allow NONE or EMPTY to reset to the default

Open
#3,480 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement priority: medium
Dominant language
Python
Stars
655
Forks
147
Avg merge
5h 27m
Merged PRs (30d)
59

Description

In `Set Selector Prefix`, the argument `${NONE}` or `${EMPTY}` simply resets the prefix to the default (which is "empty").

=> I hereby want to request to adopt the behavior of `Set Browser Timeout` to behave the same way:

```
# not necessary anymore
${old}= Set Browser Timeout 2
# (do something)
Set Browser Timeout ${old}

# instead:
Set Browser Timeout 2
# (do something)
# I don't care what the old value was, just reset
Set Browser Timeout ${EMPTY}
```
PS:
Perhaps also allow this one?
`Set Browser Timeout default`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of the `Set Browser Timeout` keyword and compare its handling with `Set Selector Prefix`, which already accepts `${NONE}` and `${EMPTY}`. Check the related tests or keyword entry points; done means resetting the browser timeout with `${NONE}` or `${EMPTY}` behaves like the default, with the optional `default` spelling clarified.

Written by the indexing model from the issue text.

Assessment

Tech stack
playwright, python
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.