MarketSquare / MarketSquare/robotframework-archivelibrary

"filename" of "archive_should_contain_file" should support regex

Open
#45 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
21
Forks
24
PR merge metrics
No merged PRs in 30d

Description

The **archive_should_contain_file(self, zip_file, filename)** function currently accepts filename as a static string. To enhance the flexibility and usability of this function, it should also support filename in regex format.

to fix this, i put this line of code:
`self.collections.should_contain_match(files, filename)`
instead of this line of code:
`self.collections.list_should_contain_value(files, filename)`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for archive_should_contain_file(self, zip_file, filename) and inspect its current filename handling. Compare the existing list_should_contain_value(files, filename) call with the proposed should_contain_match(files, filename) call. Done means the function accepts regex-formatted filenames while retaining the intended archive-content check.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.