MarketSquare / MarketSquare/roboswag

Pass either model object or dictionary to the body parameter

Open
#23 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
29
Forks
3
PR merge metrics
No merged PRs in 30d

Description

At this moment, the body parameter only accepts dictionary, which can be optionally validated by providing a boolean value for validate_payload parameter. The endpoint methods should also accept providing the payload using an object that later can be serialized into a dictionary.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the endpoint methods that define the body and validate_payload parameters, then read how dictionary payloads are currently validated and serialized. Done means those methods accept either a dictionary or a model object, while preserving the existing optional validation behavior; add or update tests for both payload forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.