MarketSquare / MarketSquare/SwingLibrary
Select Table Cell Area accepting Strings mixes up row and column IDs
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 117
- Forks
- 69
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
keyword Select Table Cell Area mixes up arguments provided as strings (check below snippet from TableOperator.java):
private void selectCellArea(int startRow, int endRow, int startColumn,
int endColumn) {
jTableOperator.setRowSelectionAllowed(true);
jTableOperator.addRowSelectionInterval(startRow, endRow);
jTableOperator.setColumnSelectionAllowed(true);
jTableOperator.addColumnSelectionInterval(startColumn, endColumn);
}
public void selectCellArea(String startRow, String endRow,
String startColumn, String endColumn) {
selectCellArea(Integer.valueOf(startColumn),
Integer.valueOf(endColumn), Integer.valueOf(startRow),
Integer.valueOf(endRow));
}
selectCellArea accepting cell coordinates as strings puts Integer.valueOf(startColumn) into startRow parameter etc.
Best regards,
Damian Wojtanowski
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in TableOperator.java at the integer and String overloads of selectCellArea and compare the parameter order between them. Verify the row and column intervals selected for string coordinates, then run the existing SwingLibrary table-operator tests if available and confirm the string overload behaves like the integer overload.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- desktop, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100