MarketSquare / MarketSquare/SSHLibrary

'Execute command' keyword's 'output_during_execution' returns encoded "byte string".

Open
#433 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
167
Forks
145
PR merge metrics
No merged PRs in 30d

Description

When using 'output_during_execution' the logged messages are returned without being properly decoded.
Example can be seen below:
Capture3
An uglier output, new lines are lost too:
Capture6

I was able to solve this issue by modifying the following by adding decoding:
Capture4

Is this solution acceptable? Is there something I am missing and this is only an issue on my end?
If this is a legitimate bug, can this solution be included in a future release?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the implementation of the Execute command keyword and trace how output_during_execution handles command output. Reproduce the encoded byte-string output, then verify that decoded messages preserve newlines and that the existing command behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.