MarketSquare / MarketSquare/SSHLibrary
Use passphrase argument for Login with Public Key keyword
- Dominant language
- Python
- Stars
- 167
- Forks
- 145
- PR merge metrics
- No merged PRs in 30d
Description
PR #267 replaces password argument with passphrase when using Login with Public Key keyword and the behavior is the expected one: The keyword fails when an invalid key is provided regardless of the credentials.
The problem is that passphrase argument was added very recently in paramiko, starting from version 2.4 according to their documentation. SSHLibrary supports all paramiko versions starting from 1.15.3 and merging this PR would make it backward incompatible with almost all older versions.
The PR should be merged when SSHLibrary will drop support for older versions of Paramiko.
Contributor guide
No contributing guide indexed for this repository
Research direction
Read PR #267 and this issue’s compatibility notes first, then check the documented Paramiko support range, especially the introduction of the passphrase argument in version 2.4. The work is complete only when SSHLibrary can adopt the PR without breaking its stated support for older Paramiko versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100