MarketSquare / MarketSquare/Robot-Framework-Mainframe-3270-Library
screenshot.py changes: Html2Image logging and option to discard the html screenshot
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 47
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
Hi, when I recently used the library for the first time, I encountered two things in the screenshot lib that gave me issues:
1. by default class Html2Image generates terminal logging. As I'm using this log to monitor test progress, I want to disable this (unnecessary) logging
2. when using the keyword Take Screenshot with the png option, the html screenshot is also generated. I don't need both, so I want to have an argument to discard the html if a png is created.
Let me know what you think. I have a changed file `screenshot.py` ready if you agree to this change.
Cheers, Jeroen
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading screenshot.py, especially the Html2Image behavior and the Take Screenshot keyword handling for the png option. The change is complete when logging can be disabled and users can choose whether the HTML screenshot is retained when a PNG is generated; no test file is mentioned, so identify the relevant test entry point before editing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100