Marcuccio / Marcuccio/cvm

Data streams

Open
#1 4 comments 1 reaction 1 assignee Claimed by @Marcuccio View on GitHub
enhancement
Dominant language
Rust
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

I see the `estimate()` function is limited to a vector of `String`, but the CVM algorithm is a lot more powerful than that.

Why not a function signature like this?

```rust
fn estimate(source: impl IntoIterator, delta: f64, epsilon: f64) -> usize
where
T: PartialOrd + PartialEq,
```

Or a structure?

```rust
let mut estimator = Estimator::::new();

estimator.push("hello".to_string());
estimator.push("bye".to_string());
estimator.push("hello".to_string());

let num_words = estimator.estimate();

assert_eq!(num_words, 2);
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.