Maratyszcza / Maratyszcza/PeachPy
Why is PUSH(r32/m32) not supported?
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 170
- PR merge metrics
- No merged PRs in 30d
Description
Error: "Invalid operand types: PUSH r32"
From the source code:
class PUSH(Instruction):
"""Push Value Onto the Stack"""
def __init__(self, *args, **kwargs):
"""Supported forms:
* PUSH(imm32)
* PUSH(r16/m16)
* PUSH(r64/m64)
"""
Is it intended that PUSH(r32/m32) is missing?
Same for POP
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the PUSH instruction definition shown in the issue and inspect how its existing r16/m16 and r64/m64 forms are represented. Check the corresponding POP implementation and the project's operand-validation or instruction tests; done means valid r32/m32 forms are accepted for both instructions without breaking the existing forms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100