Marak / Marak/translate.js

Allow translate.text to accept a string for callback in browser context

Open
#6 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
320
Forks
58
PR merge metrics
No merged PRs in 30d

Description

In the browser context, it is slightly more efficient (depending on the use case) for a user of translate.js to pass a string as the callback, which is the name of the global function that will be used when the jsonp request is complete. Besides that it is a nice additional feature I think.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing translate.text through the browser path to the JSONP request and inspect how its callback is currently handled. Done means a callback string naming a global function is accepted in the browser context and used when the JSONP request completes; verify the behavior with the repository's relevant tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.