Bad variables from copy/paste?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 385
- Forks
- 60
- PR merge metrics
- No merged PRs in 30d
Description
starting on line 59 of node_mailer.js, it seems that the callbacks for handling close and empty have been copy/pasted from the addClient method and those two methods use different names for the hostClients/hostpool variables so the callbacks fail in the send method.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in node_mailer.js around line 59 and compare the close and empty callbacks with the corresponding callbacks in addClient. Trace how send invokes them and confirm the hostClients/hostpool names match the variables in scope; done means send no longer fails for these callbacks. Check the README first because the repository is marked deprecated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 20/100