Marak / Marak/node_hash

Support multiple encodings

Open
#2 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
58
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Currently node_hash only supports the 'hex' encoding. So it's impossible to use 'ascii' or 'utf8'.

Should be an easy fix: Add encoding to exported methods, default to 'hex' if nothing passed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the node_hash exported methods and how they currently handle the 'hex' encoding. Add an optional encoding argument that defaults to 'hex' when omitted, then verify that 'ascii' and 'utf8' are accepted without changing existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.