Missing return statement?
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 291
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
Once we've loaded a font, we don't need to parse the same font right? I believe we need to have a return statement here:
https://github.com/Marak/asciimo/blob/master/lib/asciimo.js#L34
Otherwise we get the callback fn() called twice. That caused some confusion when using the nodejs async library.
Regards, Kam
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/asciimo.js at the linked line and trace the font-loading callback, especially the path taken when the font is already loaded. Verify the behavior with the existing project checks, if available, and confirm that each load request invokes its callback only once.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100