MapColonies / MapColonies/ts-server-boilerplate
Unused and inconsistent IConfig
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 12h 1m
- Merged PRs (30d)
- 2
Description
**Describe the bug**
exported `IConfig` interface is unused
**To Reproduce**
Steps to reproduce the behavior:
1. Go to `src/common/interfaces.ts`
2. `IConfig` is unused by other code and declares `get` (different signature) & `has` (not implemented by @map-colonies/config)
**Expected behavior**
Remove `IConfig` and use `ConfigType`
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Additional context**
Add any other context about the problem here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/common/interfaces.ts and inspect the exported IConfig declaration and any references to it. Replace its usage with ConfigType as requested, ensuring the inconsistent get and unsupported has members are no longer part of the interface. Done means IConfig is removed and the project still has no references to it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100