MapColonies / MapColonies/schemas
Validation bug?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 1
- Avg merge
- 28m
- Merged PRs (30d)
- 1
Description
Hey!
We've created the following property:
```
{
"type": "number",
"description": "some description",
"x-env-value": "ENV_PROP",
"default": false
}
```
It passed the package's validation using `npm run validation`. `default: false` of course is wrong.
For default `false`, I think the validation should fail.
What do you think?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running `npm run validation` with the property shown in the issue and trace the validation entry point to identify which rule accepts the mismatched `default` value. Done means the same schema is rejected when `type` is `number` and `default` is `false`, with the relevant validation coverage updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100