MapColonies / MapColonies/node-osm-elements

Type of the version property

Open
#13 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

in base element the type of version is number, but in change its string. what is the intended type?
https://github.com/MapColonies/node-osm-elements/blob/36b79146789882b85af964cbf664483369740d72/src/index.ts#L5
https://github.com/MapColonies/node-osm-elements/blob/36b79146789882b85af964cbf664483369740d72/src/index.ts#L36

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the version declarations at src/index.ts#L5 and src/index.ts#L36, then inspect the surrounding type definitions to determine the intended representation. Done means the version type is consistent between the base element and change definitions, with the intended choice clear from the resulting code or discussion.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.