MapColonies / MapColonies/config

init config error handling

Open
#14 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

long story - short story :
scenario: making config initialization with offlinemode=false, so it tries to connect to the config server.

expected results:
it will be connected to the server if it is successful, if failed, it will return east to understand the error message.

actual:-
on **success** - it's greater :-)

on some errors:
**If the server does not exist**: "ConfigError [httpGeneralError]: An error occurred while making the request" good response.

**if the server does not exist and the page it reached is not JSON** - got an error from undici about bad parsing

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing config initialization with offline mode disabled against a nonexistent server that returns non-JSON, then trace the initialization and request error entry points. Done means both connection failure cases return an understandable ConfigError rather than an uncaught parsing error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.