MapColonies / MapColonies/code-generator

Excplicit graphQL nullable FALSE not working

Open
#7 0 comments 0 reactions 1 assignee View on GitHub

@asafMasa is already working on this.

Since May 18, 2021.

bug
Dominant language
TypeScript
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
When explicitly graphQL field decorated with nullable false in generated graphQL code still nullable(optional)

**To Reproduce**
Decorate filed as following
_@graphql({
**nullable: false**
})
public id = 'UNKNOWN';_

**Expected behavior**
In generated graphQL code field should be
**@Field({ nullable: false })
public id: string;**

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.