ManimCommunity / ManimCommunity/manim
`CurvesAsSubmobjects` error messages contain hardcoded class names
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 40.9k
- Forks
- 3.1k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 25
Description
The class `CurvesAsSubmobjects` throws two custom error messages for when it either has no submobjects or it has no submobjects with points:
https://github.com/ManimCommunity/manim/blob/cafc63919eb03d398d7038a8c82e591b12de8da5/manim/mobject/types/vectorized_mobject.py#L2858-L2874
I think it would be a good idea for these error messages to dynamically show the name of the class rather than a hardcoded "`CurvesAsSubmobjects`" string so the error message automatically updates for any subclasses or if the class name ever changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in manim/mobject/types/vectorized_mobject.py around lines 2858-2874, where CurvesAsSubmobjects raises the two custom errors. Update the messages so they use the relevant class name rather than a hardcoded string, and confirm both messages also reflect subclasses or future class renames.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 85/100