ManimCommunity / ManimCommunity/manim
Strengthen strict=False passes to zip() calls
- Dominant language
- Python
- Stars
- 40.9k
- Forks
- 3.1k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 25
Description
In PR #4520, commit c14f3bbaaff021f1e2030cc88bcd6fe70d00f946 added `strict=False` to many `zip()` calls across the codebase to resolve ruff linting issues.
This was necessary to suppress warnings about zip calls without explicit strict parameters. However, these should ideally be reviewed and strengthened where possible - either by:
1. Using `strict=True` where the iterables are known to have equal length
2. Adding proper validation logic to handle mismatched lengths
3. Refactoring code to avoid zip entirely where appropriate
The commit touched ~37 files across the codebase, so this is a non-trivial cleanup task but would improve code quality and catch potential bugs earlier.
**References:**
- Commit: c14f3bbaaff021f1e2030cc88bcd6fe70d00f946
- Message: "chore: resolve zip without explicit strict calls with strict=False everywhere"
Contributor guide
Research direction
Start by inspecting commit c14f3bbaaff021f1e2030cc88bcd6fe70d00f946 and its roughly 37 changed files to inventory the zip() calls using strict=False. Review each call for equal-length guarantees, validation opportunities, or cases better refactored without zip; the cleanup is done when appropriate calls use strict=True or safer alternatives and the lint issues remain resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100