ManimCommunity / ManimCommunity/manim

The second parameter should not be named with a fixed literal string "dt"

Open
#3,197 5 comments 0 reactions 0 assignees View on GitHub
documentation needs discussion refactor
Dominant language
Python
Stars
40.9k
Forks
3.1k
Avg merge
3d 12h
Merged PRs (30d)
25

Description

Usually function parameters are dummy variables that can be named anything.
Forcing us to use `dt` just adds unnecessary confusion to users.

https://github.com/ManimCommunity/manim/blob/117563e1f01adafe675f011ad425a257753ec9f4/manim/mobject/mobject.py#L975

Contributor guide

Open the contributing guide

Research direction

Start at manim/mobject/mobject.py around line 975 and inspect the second parameter's definition and uses. Determine an appropriate non-fixed parameter name, update the affected references, and run the relevant tests to confirm the API still behaves correctly without requiring the literal "dt".

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.