ManimCommunity / ManimCommunity/manim
Changing implementation of SVGMobject handle commands until the other API is done
Open
@MrDiver is already working on this.
Since Dec 24, 2022.
maintenance
refactor
- Dominant language
- Python
- Stars
- 40.9k
- Forks
- 3.1k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 25
Description
https://github.com/ManimCommunity/manim/blob/d3b96dd68c12bef84ba5ac7b3f9d83ed58bdc0e3/manim/mobject/svg/svg_mobject.py#L499-L524
This code is very confusing and i tested this with some if statements and there doesn't seem to be a performance difference. This issue is just to remind myself of commiting that code at some point.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.