ManimCommunity / ManimCommunity/manim
`turn_animation_into_updater` does not respect `run_time` correctly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 40.9k
- Forks
- 3.1k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 25
Description
Description of bug / unexpected behavior
Multiple animations passed in turn_animation_into_updater react in an odd way, disregarding their respective run times.
Expected behavior
In the example code, it is expected to wiggle and indicate the text according to their run_time values.
How to reproduce the issue
Code for reproducing the problem
class Test(Scene):
def construct(self):
text = Tex(r"Here is some text", color=WHITE)
self.play(FadeIn(text))
turn_animation_into_updater(Wiggle(text, run_time=1))
turn_animation_into_updater(Indicate(text, run_time=1))
self.wait(2, frozen_frame=False)
A more correct result would need specific run_time values:
class Test(Scene):
def construct(self):
text = Tex(r"Here is some text", color=WHITE)
self.play(FadeIn(text))
turn_animation_into_updater(Wiggle(text, run_time=8))
turn_animation_into_updater(Indicate(text, run_time=2))
self.wait(2, frozen_frame=False)
Additional media files
Images/GIFs
The correct result:
Logs
Terminal output
PASTE HERE OR PROVIDE LINK TO https://pastebin.com/ OR SIMILAR
System specifications
System Details
- OS (with version, e.g., Windows 10 v2004 or macOS 10.15 (Catalina)):
- RAM:
- Python version (
python/py/python3 --version): - Installed modules (provide output from
pip list):
PASTE HERE
LaTeX details
- LaTeX distribution (e.g. TeX Live 2020):
- Installed LaTeX packages:
FFMPEG
Output of ffmpeg -version:
PASTE HERE
Additional comments
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation of turn_animation_into_updater and inspect how it advances Wiggle and Indicate animations. Run the provided Test scene with different run_time values, then verify that each updater follows its own duration while the animations overlap. Add or update focused tests if the project has coverage for this helper.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100