ManimCommunity / ManimCommunity/manim
Confusion about index of tip in Brace.get_tip
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 40.9k
- Forks
- 3.1k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 25
Description
We should add some documentation on why the 35th point in `self.get_points()` corresponds to the tip of the brace in `brace.py`.
---
A comment for where 34 comes from would be great.
_Originally posted by @behackl in https://github.com/ManimCommunity/manim/pull/1572#discussion_r641980133_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in brace.py at Brace.get_tip and inspect how self.get_points() is indexed there. Document why the 35th point, or index 34, represents the brace tip, and confirm the comment accurately reflects the point construction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-graphics
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100