ManimCommunity / ManimCommunity/manim

add_sound method and turn_animation_into_updater function not working properly

Open
#1,266 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

issue:bug
Dominant language
Python
Stars
40.9k
Forks
3.1k
Avg merge
3d 12h
Merged PRs (30d)
25

Description

Whenever manim uses partial video from cache, the add_sound method fails to add sound in the expected times in the video, meaning, the sound is played few seconds before the expected time to play the sound.

The turn_animation_into_updater function gives error that animation class has no attribute update_config.

Please fix these problems ASAP.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the add_sound timing failure when Manim uses partial video from cache, then reproduce the update_config error from turn_animation_into_updater. The issue is done when cached partial-video renders place sound at the expected times and the animation conversion no longer raises the reported attribute error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.