ManagedBass / ManagedBass/ManagedBass

WaveFileWriter.Dispose close base stream but this is not always needed

Open
#115 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C#
Stars
285
Forks
55
PR merge metrics
No merged PRs in 30d

Description

if i use WaveFileWriter with MemoryStream then WaveFileWriter.Dispose releases MemoryStream by following code:

_ofstream.Dispose(); // will close the underlying base stream
_ofstream = null;

After that I can't use MemoryStream
Is it possible to add a some parameter to WaveFileWriter indicating whether to release the base stream or not?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate WaveFileWriter and inspect Dispose, especially the _ofstream.Dispose() call shown in the issue. Determine how stream ownership is represented, then make the requested behavior configurable and verify that a supplied MemoryStream remains usable when ownership is disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
audio-video-rtc
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.