ManageIQ / ManageIQ/miq_bot

cross-repo-test runs inline in the NotificationMonitor

Open
#845 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug stale
Dominant language
Ruby
Stars
16
Forks
39
Avg merge
1d 11h
Merged PRs (30d)
8

Description

cross-repo-test runs inline in the NotificationMonitor. This means it has to process the entire thing before moving on to the next notification. The NotificationMonitor was designed around more lightweight tasks like adding a label, so cross-repo-test should probably be done as a dedicated sidekiq worker.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the NotificationMonitor and the code path that runs cross-repo-test inline. Read how notifications are processed and how Sidekiq workers are defined in the repository before deciding the worker boundary. Done means cross-repo-test runs in a dedicated worker and the monitor can move on to subsequent notifications independently.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.