ManageIQ / ManageIQ/miq_bot

Specifying `travis_event` in settings causes failure

Open
#227 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted pinned
Dominant language
Ruby
Stars
16
Forks
39
Avg merge
1d 11h
Merged PRs (30d)
8

Description

While following the instructions for setting up the bot, if you have something like the following in your settings yml:

travis_event:
  enabled_repos:
    - notchrisarcand/sandbox

You will receive the following fatal error trying to start the bot:

14:26:23 travis_listener.1 | rake aborted!
14:26:23 travis_listener.1 | Travis::Client::NotFound: {"file":"not found"}
14:26:23 travis_listener.1 | /Users/carcand/workspace/manageiq/miq_bot/lib/travis_event/listener.rb:36:in `block in travis_repos'
14:26:23 travis_listener.1 | /Users/carcand/workspace/manageiq/miq_bot/lib/travis_event/listener.rb:36:in `collect'
14:26:23 travis_listener.1 | /Users/carcand/workspace/manageiq/miq_bot/lib/travis_event/listener.rb:36:in `travis_repos'
14:26:23 travis_listener.1 | /Users/carcand/workspace/manageiq/miq_bot/lib/travis_event/listener.rb:22:in `monitor'
14:26:23 travis_listener.1 | /Users/carcand/workspace/manageiq/miq_bot/lib/travis_event/listener.rb:17:in `run'
14:26:23 travis_listener.1 | /Users/carcand/workspace/manageiq/miq_bot/lib/tasks/travis_event_listener.rake:4:in `block (2 levels) in <top (required)>'
14:26:23 travis_listener.1 | /Users/carcand/.rbenv/versions/2.2.5/bin/bundle:23:in `load'
14:26:23 travis_listener.1 | /Users/carcand/.rbenv/versions/2.2.5/bin/bundle:23:in `<main>'
14:26:23 travis_listener.1 | Tasks: TOP => travis_event_listener:run
14:26:23 travis_listener.1 | (See full trace by running task with --trace)
14:26:23 travis_listener.1 | exited with code 1
14:26:23 system            | sending SIGTERM to all processes

Whatever causes it might want to be handled more gracefully.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lib/travis_event/listener.rb at line 36, where travis_repos is shown failing, and inspect the listener task in lib/tasks/travis_event_listener.rake. Reproduce the startup with the provided travis_event settings and determine how the Travis::Client::NotFound failure should be handled gracefully; done means the bot no longer aborts fatally for this configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.