ManageIQ / ManageIQ/miq_bot

Don't run linters on backport PRs

Open
#206 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted pinned
Dominant language
Ruby
Stars
16
Forks
39
Avg merge
1d 11h
Merged PRs (30d)
8

Description

When backporting it's probably better to keep the code in the same form as the original PR and not make any further changes. As such, we probably want to disable rubocop and haml-lint on PRs to non-master. This may be doable by reusing the branch disablement code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the existing branch disablement code and the logic that runs RuboCop and haml-lint on pull requests. Trace how the target branch is identified for backport PRs, then verify that PRs targeting non-master branches skip both linters while master PRs retain their current behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
ci-cd, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.