New OffenseMessage builder does not sort locators properly.
Open
Nobody has claimed this yet.
bug
help wanted
pinned
- Dominant language
- Ruby
- Stars
- 16
- Forks
- 39
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 8
Description
Since it does string sort, `Line 103` comes before `Line 5`. We probably need to change locator from being string based to being numeric, or specific on line vs commit_sha or something. @bdunne
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by locating the New OffenseMessage builder and the code that sorts its locators, then inspect how line and commit_sha locators are represented. Done means locators sort numerically so Line 5 precedes Line 103, with the relevant existing tests updated or added.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100