ManageIQ / ManageIQ/kubeclient
Psych.safe_load deprecated calling convention (ruby 2.6+)
Open
Nobody has claimed this yet.
bug
help wanted
- Dominant language
- Ruby
- Stars
- 426
- Forks
- 171
- PR merge metrics
- No merged PRs in 30d
Description
warnings seen in test output:
lib/kubeclient/config.rb:33: Passing permitted_classes with the 2nd argument of Psych.safe_load is deprecated. Use keyword argument like Psych.safe_load(yaml, permitted_classes: ...) instead.
test/test_config.rb:128: Passing permitted_classes with the 2nd argument of Psych.safe_load is deprecated. Use keyword argument like Psych.safe_load(yaml, permitted_classes: ...) instead.
test/test_config.rb:137: Passing permitted_classes with the 2nd argument of Psych.safe_load is deprecated. Use keyword argument like Psych.safe_load(yaml, permitted_classes: ...) instead.
I initially assumed they're new in 2.7 but they're actually since 2.6.0.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/kubeclient/config.rb:33 and the calls at test/test_config.rb:128 and :137. Check the Psych.safe_load documentation for Ruby 2.6+ and run the configuration tests; done means the deprecated-calling-convention warnings no longer appear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100