MaikuB / MaikuB/flutter_appauth
[flutter_appauth] iOS app would crash when authorizationCode was nil
- Dominant language
- Objective-C
- Stars
- 308
- Forks
- 301
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 5
Description
iOS app would crash when `authorizationCode` was `nil`
Error message in Obj-C:
>The operation couldn’t be completed. *** -[__NSDictionaryM setObject:forKey:]: object cannot be nil (key: authorizationCode)
The exception is thrown here: https://github.com/MaikuB/flutter_appauth/blob/master/flutter_appauth/ios/Classes/AppAuthIOSAuthorization.m#L86-L89
This PR #588 prevents the app from crashing by catching the exception and sending it to the UI.
Contributor guide
Research direction
Review PR #588 and the code at ios/Classes/AppAuthIOSAuthorization.m:86-89 first. Confirm that a nil authorizationCode is reported to the UI without the iOS crash described in the error message; the issue notes that PR #588 addresses this.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- flutter, ios, objective-c
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100