MaibornWolff / MaibornWolff/codecharta
Reenable urlextractor tests
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 529
- Forks
- 56
- Avg merge
- 7h 17m
- Merged PRs (30d)
- 34
Description
## Description
When we updated the jest version the urlextractor tests were no longer working. The reason is that we tried to use window.location in the tests and in angular. Which is not the preferred way. We want to use the angular router instead. This leads to a bigger rewrite of the initialload and urlextractor component.
Goal of this task is to rewrite the old solution and use angular router instead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the urlextractor tests and the initialload and urlextractor components mentioned in the issue. Trace how they currently use window.location, then update the solution to use the Angular router and confirm the urlextractor tests run successfully with the updated Jest version.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100