MaibornWolff / MaibornWolff/codecharta

Add new search dialog

Open
#4,179 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
529
Forks
56
Avg merge
7h 17m
Merged PRs (30d)
34

Description

Feature request

The search works pretty well in the map. It does not work well in the node explorer. When I search for something that is one folder or more below what I have expanded, I do not see what the search found. See this search for "model", which is inside analysis but also inside visualization/app/codecharta:

Image

I looked around a bit and saw what IntelliJ or Spotlight do and I think we can improve search fundamentally.

Description

As an auditor, I want a new search dialog that clearly shows the search result.

I think the existing node explorer is not the perfect place for the search result, because the node explorer has the tree structure is not so helpful. I checked what IntelliJ does and I think searching for something should open a new dialog that shows only what is matched. It could look like this:

Image

Depending on if the user clicks on a search result, the new dialog would then show either the old node explorer or select the search result in the node explorer:

Image

What do you think?

Acceptance criteria

  • Searching for something opens a new search dialog that shows what files are matched
    • in the map
    • not in the map, because it has no area metric
    • in flattened files
    • in excluded files
  • Selecting something in the new dialog shows the old node explorer again with the element selected
  • Pressing enter without selecting something shows the old node explorer again but indicates via color inside which folder the search result is

Assumptions & Exclusions

Development notes (optional Task Breakdown)

Open questions

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named in the issue. Start by locating the existing map and node-explorer search implementation, then trace how results are selected and displayed. Done means a dialog covers all listed result categories and returns to the node explorer with the specified selection or folder indication.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.