MahApps / MahApps/MahApps.Metro
TimePicker SelectedTime
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 9.8k
- Forks
- 2.4k
- Avg merge
- 1h 2m
- Merged PRs (30d)
- 56
Description
## TimePicker should have a property for time-only values (as the name of the control)
TimePicke use a SelectedDateTime property for selected value which use a DateTime?, this is pretty funny because for this kind of value we can user DatePicker (which can show the time part), for time property there's a TimeSpan so why (in an approved PR) you changed this behavior?
In .net Time are represented by TimeSpan, if you wan't break current implementation please add a SelectedTime property to use the correct data type instead of using a converter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the TimePicker control's existing SelectedDateTime property and compare the requested TimeSpan-based SelectedTime behavior with DatePicker usage. Done means the control exposes the requested time-only value without breaking the existing implementation, with relevant behavior covered by the project's tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100