MagicStack / MagicStack/py-pgproto
Tiny fix in hton.h
Open
Nobody has claimed this yet.
- Dominant language
- Cython
- Stars
- 38
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
Should the argument x here have type int32_t?
pack_int32(char *buf, int64_t x)
I understand that the current version will produce exactly the same result.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open hton.h and inspect the pack_int32 declaration and its callers. Check whether changing the x parameter from int64_t to int32_t is consistent with those uses and preserves the stated result; done means the signature is corrected if appropriate without changing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100