MagicStack / MagicStack/httptools
How to do an early stop?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.3k
- Forks
- 107
- PR merge metrics
- No merged PRs in 30d
Description
Hi there 👋
I'm trying to implement a flag --limit-request-header-count on uvicorn, which I implemented changing the value of an attribute too_many_headers and raising an exception from on_header callback, see https://github.com/encode/uvicorn/pull/1683/files.
My question is: is my implementation as intended? Should the HttpParserCallbackError send more information when an exception happens from one of the callbacks?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the proposed uvicorn PR #1683, focusing on the too_many_headers attribute and the on_header callback mentioned in the issue. Determine whether HttpParserCallbackError should expose more information from callback exceptions and whether the proposed early-stop behavior is intended; completion requires an agreed implementation direction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100