MagicStack / MagicStack/asyncpg
Connection secrets displayed in clear text in logs
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.1k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
When i have this error : 'remaining connection slots are reserved for', the password is displayed in clear text in the logs:
`ConnectionParameters(user='', password='', ...`
The usage of `SecretStr`(pydantic) or something equivalent will solve the issue
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how ConnectionParameters is represented when the "remaining connection slots are reserved for" error is logged. Check the existing logging and error-handling coverage, then add regression coverage showing that the password is no longer displayed in clear text while the useful connection details remain available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- postgresql, python
- Domain
- databases, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100