MagicStack / MagicStack/MagicPython

Syntax highlighting issue when @ appears as first character after line continuation when indexing is present

Open
#253 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.4k
Forks
98
PR merge metrics
No merged PRs in 30d

Description

* **Editor name and version**: VS Code 1.71
* **Platform**: Any
* **Color scheme**: NA
* **MagicPython version**:
* **A sreenshot**:
I would expect syntax highlighting to be the same irrespective of whether the line is broken before or after the @ operator.
![image](https://user-images.githubusercontent.com/38270282/191928430-57478e2a-0077-4ef6-998e-c340ad2537af.png)

* **5-10 lines of surrounding code**:
```python
# Define variables so pylance doesn't complain.
long_variable_name = other_long_variable_name = 1

long_variable_name \
@ other_long_variable_name['some_index']

long_variable_name @ \
other_long_variable_name['some_index']
```

Originally from @tillahoffmann in https://github.com/microsoft/vscode/issues/161435

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the reported Python snippet in a supported editor, comparing highlighting when the line continuation appears before versus after @ and an indexed expression follows. Trace the syntax-highlighting grammar entry point for line continuations and @ expressions; done means both equivalent forms receive the same highlighting.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.