MagicStack / MagicStack/MagicPython

python string syntax highlight errors

Open
#245 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.4k
Forks
98
PR merge metrics
No merged PRs in 30d

Description

* **Editor name and version**: VS Code 1.62+
* **Platform**: Any
* **Color scheme**: Any
* **MagicPython version**: latest commit from main
* **A sreenshot**:
![image](https://user-images.githubusercontent.com/38270282/143234569-a8df39d5-e9f3-487d-b4f3-a21fede36b24.png)

* **5-10 lines of surrounding code**:
```python
# This is not an f-string, but VSCode highlights `workspaceFolder' like a variable.
a = "${workspaceFolder}"
```

Originally filed by @mikisama in https://github.com/microsoft/vscode/issues/137694

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Python syntax-highlighting rules used by MagicPython and reproduce the behavior in VS Code 1.62+ using the issue's example, `a = "${workspaceFolder}"`. Check how quoted strings classify `${workspaceFolder}` when the string is not an f-string; done means the example no longer receives variable highlighting while f-strings retain their expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.