MagicStack / MagicStack/MagicPython

Incorrect tokenization of querystring

Open
#243 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.4k
Forks
98
PR merge metrics
No merged PRs in 30d

Description

* **Editor name and version**: VS Code 1.62
* **Platform**: Any
* **Color scheme**: N/A
* **MagicPython version**: Most recent commit from master
* **A sreenshot**:
![image](https://user-images.githubusercontent.com/38270282/142603906-b022550c-6e0a-4550-baf2-42a221465fbb.png)

* **5-10 lines of surrounding code**:
```python
url = 'https://www.foo.com/bar?quux=%7B%22persistedQuery%22%3A%7B%22version%22%3A1%2C%22sha256Hash%22%3A%...%22%7D%7D'
```

Originally from @p-i- in https://github.com/microsoft/vscode/issues/137461

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the provided Python URL string in VS Code 1.62 with the latest MagicPython commit and compare its tokenization with the screenshot. No source file or test is named, so locate the query-string handling in the syntax highlighter and add a regression check once the expected highlighting is established.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python, vscode
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.