MagicStack / MagicStack/MagicPython

Short constant names highlighted incorrectly

Open
#135 4 comments 0 reactions 1 assignee View on GitHub

@vpetrovykh is already working on this.

Since Jul 20, 2018.

Dominant language
JavaScript
Stars
1.4k
Forks
98
PR merge metrics
No merged PRs in 30d

Description

Hi. 👋

Short constant names seem to be highlighted incorrectly. I got the assumption that the bug might lie in this MagicPython package. What do you guys think? I ran across this while coding a project, and thought that I should do something about it.

* **Editor name and version**: Visual Studio Code 1.23.1
* **Platform**: macOS 10.12.6
* **Color scheme**: Dracula
* **MagicPython version**: Default in Visual Studio Code 1.23.1

## VSCode Example

example

## GitHub Example

```python

LONGER = "Yeshh!"
B = "What?"

class SomeClass:
MEMBER = 1
MEMBER2 = 2
A = 3
ARE = 123
A85 = "Something"

```
I would also like to give special mention to short constant names that end in numbers. They don't seem to be highlighted correctly, even though the same length character-based constants do.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.