MagiCircles / MagiCircles/SchoolIdolAPI

Limited URs should be able to have more than 2 skill slots

Open
#321 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
151
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Limited URs (promo URs obtained from the limited scouting boxes in JP like #1319, #1417, and #1425) are able to have more than 2 SIS slots (I believe they start with 4?) but it's not letting me input more than 2 skill slots for these cards.
I think it'd be better to have a separate category for these cards rather than "Promo" because they're more powerful and are scouted rather than given out.

![img-5178](https://user-images.githubusercontent.com/27237273/35782606-377d2182-09af-11e8-8048-8f353474a0dc.JPG)
![img-5133](https://user-images.githubusercontent.com/27237273/35782607-37f80960-09af-11e8-8f1f-fcf0e3c6a486.JPG)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by locating the card data and skill-slot handling for promo and limited UR cards, then compare the examples in issues #1319, #1417, and #1425. Done means limited URs accept more than two skill slots and are distinguished appropriately from ordinary promo cards.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.